Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JR-863] 댓글 수정, 로딩컴포넌트 적용 #168

Merged
merged 5 commits into from
Oct 11, 2023
Merged

[JR-863] 댓글 수정, 로딩컴포넌트 적용 #168

merged 5 commits into from
Oct 11, 2023

Conversation

leejiho9898
Copy link
Member

@leejiho9898 leejiho9898 commented Oct 9, 2023 •
edited
Loading

📑 작업리스트

  • 댓글 수정기능 구현
  • 로딩 컴포넌트 생성
  • 로딩 컴포넌트 적용

📘 리뷰노트

  • 레퍼런스만 있어서 그냥 제가 임의로 디자인 적용했습니다
    스크린샷 2023-10-09 오후 11 54 16

@vercel
Copy link

vercel bot commented Oct 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jurumarble ✅ Ready (Inspect) Visit Preview Oct 9, 2023 2:58pm
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 2:58pm

@github-actions github-actions bot requested a review from Leejha October 9, 2023 14:57
Leejha
Leejha approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@Leejha Leejha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로딩 컴포넌트 지정해준걸로 기억하는데 저도 찾지를 못하겠네요

@leejiho9898 leejiho9898 merged commit d225119 into develop Oct 11, 2023
2 checks passed
@leejiho9898 leejiho9898 deleted the JR-863-loading-component branch October 11, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leejha Leejha Leejha approved these changes

Assignees

@leejiho9898 leejiho9898

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leejiho9898 @Leejha